Fix indentation in exported markdown results#1693
Conversation
koesie10
left a comment
There was a problem hiding this comment.
LGTM
Do you think it might make sense to use code blocks using ``` as a future improvement?
I believe the reason we don't use ``` is because we want to add styling within the code block to highlight a specific bit. The code blocks don't allow you to add extra styling within them, though they do give other benefits like syntax highlighting and avoiding markdown indentation weirdness like this. |
|
Thanks for the review, @koesie10 ✨
Indeed! We can't add HTML styling (such as |
This PR fixes the markdown export for remote query results. Previously, paths with more than 100 steps had their code snippets badly indented, which caused the markdown to render badly on GitHub Gists.
I've changed the indentation to match the length of the list number, and updated tests to check this variable indentation size.
Checklist
N/A - this is a private beta feature. See internal issue for more details!
ready-for-doc-reviewlabel there.